Fix error reading FieldTimeSeries from NetCDF#5684
Open
tomchor wants to merge 6 commits into
Open
Conversation
tomchor
changed the title
Guards against the UndefVarError regression where grid-reconstruction strings serialized as e.g. "Oceananigans.Grids.Periodic" failed to resolve in the extension module. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tomchor
changed the title
Evaluating in the Oceananigans top-level module broke values that serialize to bare, unqualified names living in submodules and not re-exported at top level (e.g. "CenterImmersedCondition()"), surfacing as `UndefVarError: CenterImmersedCondition not defined in Oceananigans` when reconstructing an immersed-boundary grid. Evaluate in the extension module instead: it imports those bare names, and the `import Oceananigans` added earlier binds `Oceananigans` so fully-qualified names (e.g. "Oceananigans.Grids.Periodic") also resolve. The union of both namespaces is what covers every serialized form. Extend the regression test to cover the bare-name forms too. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading a
FieldTimeSeriesfrom a NetCDF file is throwing an error whenOceananigansisn't in the main scope.This is because strings were
eval'd in the extension's scope, where theOceananigansname isn't bound.MWE: