Add tracer budget closure test#5679
Conversation
|
We already have some conservation tests for the hydrostatic model in |
|
Gotcha. I’ll move them there/combine. Will also perturb the free surface so that zstar is required for. |
|
apparently tracers are not conserved? |
| boundary_conditions=(c=c_bcs,), | ||
| free_surface=SplitExplicitFreeSurface(substeps=15)) | ||
|
|
||
| hydrostatic_model.free_surface.displacement[1:grid.Nx, 1:grid.Ny, grid.Nz+1:grid.Nz+1] .= 2e-1 * rand.() |
There was a problem hiding this comment.
@simone-silvestri, I perturbed the free surface but locally still the test passes, although we are not using
There was a problem hiding this comment.
I guess z-star is required if we were testing point-wise conservation, not conservation in an integral sense?
There was a problem hiding this comment.
Perhaps I don’t know what “conservation” means? Here I am testing the tracer budget and that the total tracer content changes according to the surface forcing. Seems that it doesn’t require z-star unless my test case is too simple?
Add tracer conservation tests for hydrostatic and nonhydrostatic model.
The test checks whether the total tracer changes in agreement with how much the surface flux of the tracer is.
w @taimoorsohail