Skip to content

Topology-aware operators are incorrect at N+1?#5618

Open
glwagner wants to merge 1 commit into
mainfrom
glwagner-patch-4
Open

Topology-aware operators are incorrect at N+1?#5618
glwagner wants to merge 1 commit into
mainfrom
glwagner-patch-4

Conversation

@glwagner

@glwagner glwagner commented May 21, 2026

Copy link
Copy Markdown
Member

The change in this PR illustrates what would be done if this were correct.

cc @simone-silvestri

Or do we even want

@inline δxTᶠᵃᵃ(i, j, k, grid::AGXB{FT}, f, args...) where FT = ifelse((i <= 1) | (i >= grid.Nx+1), zero(FT), δxᶠᵃᵃ(i, j, k, grid, f, args...))

The change in this PR illustrates what would be done if this were correct.

cc @simone-silvestri
@simone-silvestri

Copy link
Copy Markdown
Collaborator

Ah I guess they are incorrect for i > N, I don't think they are ever used for that specific case, but good to correct it if some method wants to use them for i > N. I think the same should then apply to i == 0 for the center operators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants