feat: add onPieceDragCancel option to handle piece drag cancellations#230
Open
miguelmato wants to merge 2 commits into
Open
feat: add onPieceDragCancel option to handle piece drag cancellations#230miguelmato wants to merge 2 commits into
miguelmato wants to merge 2 commits into
Conversation
|
@miguelmato is attempting to deploy a commit to the Ryan Gregory's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
onPieceDragCancelprop to be able to customize the UI cleanup when the user explicitly cancel a drag event by right clicking or pressing Escape.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
pnpm storybookand verified that right clicking or pressing Escape triggers the callback but drag and dropping a piece outside the board does not.pnpm test:staticlocally to ensure no TypeScript compilation errors or Prettier formattingissues were introduced by the updated ChessboardOptions type definitions.
Checklist: