separete lane connections for track/road vehicles.

[kianzarrin]

fixes #354

• hotkeys and icons from [EPIC] UI design of Lane connector tool for new features. #1479
• trolleybuses use same connections as cars.
• used Road/Track sub managers to store lane connections.
• all other data structures need to use separate arrays to store road/track connections.
• lane connection manager does not allow making unsupported lane connection of the wrong lane/vehicle type. this helps with backward compatibility too. but it does allow making backward connections when not allowed for the sake of backward compatibility on train stations. this should change in set dead ends for lanes using lane connector #1213.

Bonus:

• fixes TMPE connections is not restablished after removing lane connection #1198 : update connections when new connection is made.
• update direction arrow texture (less aliasing).

TMPE.zip

pictures are in the comments.

Tests:

• car only test: always in car mode. holding alt/shift does not change mode
• track only test: always in track mode. holding alt.shift does not change mode
• other node test: regardless of whether or not current node is car-only or track-only none-selected nodes show all car+track connections. if alt is held then they only show track connections.
• tram road test: holding alt make tram roads select-able. otherwise only car lanes are select-able.
• mixed lane mode: normally you see circle and can make car connection. holding alt shows triangle and can make track connection. holding shift can make both connections.
• bidirectional lane: node marker is diamond and you can make forward/backward connection. lane curves have arrows on them indicating their direction.
• acute+mixed test: hold shift to select mixed lanes. acute targets should show circle, and clicking them should only make car lane connection
• acute only mixed lane test: connect a road with mixed tram lane to an intersection with no other tram rods. expected: no
  target lane connection is highlighted. shift clicking will put in car mode.
• source to target test: make sure you can only make lane connection in the right direction.
• hintbox text: go through different state and check if hintbox is OK. make sure ALT/SHIFT modifiers are only there when selecting car+tram node.
• big roundabout test: make sure roundabout connector makes stay in lane is applied on entry and inside of the roundabout when there is a node too close to the roundabout and when there are nodes inside roundabout. related StayInLane gets confused with multi pupose car/track lanes. #705
• mixed lane arrow test: connect trams only on a mixed lane and make sure you can still modify lane arrows. make sure that you can't modify lane arrows if you connect cars only.
• separate turning lane: in above scenario make sure separate turning lanes is blocked iff there is a car connection.

mixed connections tests: connect car and track differently on a mixed car+tram lane and:

• mixed lane routing test: verify the are routed differently.
• refresh test: exit and reenter tool, select the node and make sure you can see all connections.
• lane arrow test: lane arrows are influenced only by car connection.
• mixed lane persistency test: make sure they connections persist when save/load game
• mixed lane record test: make sure connections can be copied by move it.

backward compatibility test:

• save game backward compatibility test: connect mixed lanes in old TMPE and saved it. make sure they get both car/track connection when loaded with this version.
• lane record backward compatibility test: connect mixed lanes in old TMPE and export it. make sure they get both car/track connection when imported with this version.

TODO:

• on mixed lanes do not allow trams to make acute lane connections.
• hints

[kianzarrin]

I ditched triangle and am using square now. Triangle looks a bit ugly and is hard to write the code.

Also the diamond is no longer filled:

[originalfoo]

Looks good!

[kianzarrin]

about backward compatibility at train stations:
In TMPE stable one lane connection like bellow is enough to make trains stay in lane.

The same is true with TMPE in this PR:

This makes backward compatibility easy. There is no need to keep connections that from target to source when loading legacy game.

Removing connections in the wrong direction also solves this issue that happens when you remove lane connections that was made using legacy TMPE:

[krzychu124]

Sync with master :)

[Elesbaan70]

I am concerned about continuing to introduce breaking file format changes. Can this all wait until the new persistence code is merged?

[kianzarrin]

This PR has waited for a month already. I don't think we need to wait more. conflicts will accumulate over time.
Is it breaking anything?

[kianzarrin]

it does not break anything for me. I made the connections bellow with TMPE from this PR then saved and loaded the game using stable TMPE:

[kianzarrin]

If we don't want to merge it with master, we should consider merging a feature branch instead of stopping this PR. but it is forward/backward compatible so I don't think this is good to go to master.

[krzychu124]

It's exactly the same situation as last time. If you save game with this build you won't be able to load it using current master or WS stable

[krzychu124]

I think it doesn't matter because the change in any of serializable configuration classes will make the savegame incompatible with previous version of deserializer (current master or any workshop version)

[Elesbaan70]

You sure about that? I encountered the problem specifically in relation to adding a new type, which is still a pretty drastic limitation when doing work of any significance, since the whole system is type-based. #1559 explains it as an issue with strongly typed serialization.

[krzychu124]

ok, did not throw exception or anything, loaded something, looks good. Ignore previous comment

[kianzarrin]

loaded something

it is both forward/backward compatible.
if you make different lane connections on mixed/car track lanes -> save -> load with earlier version of TMPE, then car/track lane connections will merge.

[krzychu124]

yeah, noticed that, looks ok.

[chameleon-tbn]

lgtm