#13 Refactor PCBWay rules to mirror JLCPCB structure#29
Open
Cimos wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13.
Brings PCBWay.kicad_dru up to the same structure JLCPCB.kicad_dru has been using since #12 was merged.
What changed
Bug fixes
'track'/'via'/'pad'to PascalCase'Track'/'Via'/'Pad'(KiCad 8 convention; the old form would silently never match in some places).hole_size (min 0.5mm)to all plated pads including SMD. Split intoPCBWay: PTH Hole Size(PTH only) andPCBWay: PTH Annular Ring.A.Net != B.Nettest — the rule name said different nets but the condition would have flagged same-net pad pairs.Added rules (backed by PCBWay's published spec)
PCBWay: Via Annular Ring— 0.15mm, per "Annular Ring (Pad Ring Width) Standard: 0.15mm(6mil)" on https://www.pcbway.com/capabilities.htmlPCBWay: PTH Annular Ring— split out from the old combined Pad Size rulePCBWay: NPTH Annular Ring— split out, value preserved (0.25mm)PCBWay: Plated Slot Width/Non-Plated Slot Width— pulled out into their own sectionPCBWay: NPTH to Copper (non-Track)— preserves the old "NPTH with copper around" rule, renamed for clarityStructure
Not done in this PR