Repository navigation
Fix fast pinch-zoom snapping back to 1x mid-gesture - #95
Merged
Merged
Conversation
The pinch/pan gesture handler never consumed pointer events, so they also reached the sibling double-tap detector on the same surface. A fast pinch, where fingers briefly report as separate down/up pairs, could register there as a double-tap, whose reset-to-1x handler fired mid-pinch. Consume events once a second finger is down or a real zoom/pan is in progress so the tap detector never sees them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
The pinch/pan gesture handler on the PDF page surface never consumed pointer events. They also reached a sibling
detectTapGestureson the same surface, which independently watches for double-taps and resets zoom to 1x on one. A fast pinch — where the touchscreen can briefly report fingers as separate down/up pairs — could get misread there as a double-tap, firing the reset mid-pinch.Fixes #93. Likely also what #92 was seeing (zoom "resetting" while reading) since zoom is a single document-level value that already persists across page scrolling by design — there's no separate per-page reset path.
How was it checked?
./gradlew :app:compileFossDebugKotlinChecklist