Repository navigation
Conversation
sapctrl tools don't have to be installed, however, the HANA instance user has a sapcontrol binary installed, try to use that first before trying the global absolut path which might not exist.
Shellcheck SC2086
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sapctrl tools don't have to be installed, however, the HANA instance user has a sapcontrol binary installed, try to use that first before trying the global absolut path which might not exist.
General information
Bug reports
On some SAP HANA systems, the SAP hostctrl tools aren't installed for the root user - however, the instance runs completely fine and SAP is fine with that. mk_sap_hana however has the absolute path of the sapcontrol binary hard coded and the sap_hana_instance_status section fails because of this.
Proposed changes
Pass the instance user to the function and let it verify first if a sapcontrol binary exists in the path of the sidadm (i.e. instance_user) and use that if it's present.
The output of the plugin does not change at all. (Except of course, it starts working like intented while it just returned a 127 exit code before)