PR4: Comprehensive Test Cases & Utility Enhancements (AST-109633)#320
Open
cx-rahul-pidde wants to merge 3 commits into
Open
PR4: Comprehensive Test Cases & Utility Enhancements (AST-109633)#320cx-rahul-pidde wants to merge 3 commits into
cx-rahul-pidde wants to merge 3 commits into
Conversation
- Add CxAssistDisplayCoordinatorAdditionalTests (422 lines) - Add CxAssistErrorListSyncTests (156 lines) - Add CompanionFileManagerTests (293 lines) - Add OssManifestSweepPolicyTests (108 lines) - Add RealtimeFileScanSchedulerTests (201 lines) - Add RealtimeSolutionScannerTests (237 lines) - Add TempFileManagerAdditionalTests (407 lines) - Add comprehensive VulnerabilityMapperTests (1332 lines) - Enhance VulnerabilityMapper with improved result mapping - Improve CompanionFileManager for lock file handling - Enhance TempFileManager and RealtimeSolutionScanner - Improve FileFilterStrategy and ManifestFileWatcher Base branch: feature/devassist-integration-branch Related to: AST-109633
|
Policy Management Violations (2)
|
…missing UpdateFindingsForFile method - Remove invalid Column property reference from CxAscaDetail in VulnerabilityMapper.cs (uses Length instead) - Add UpdateFindingsForFile method to CxAssistDisplayCoordinator for test compatibility - All C# compilation errors now resolved Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
cx-rahul-pidde
requested review from
cx-anurag-dalke,
cx-rakesh-kadu and
cx-umesh-waghode
cx-rakesh-kadu
requested changes
Apr 21, 2026
- Fix ClearFindingsFromDisabledScanners filter: use IsScannerEnabled() instead of v.Scanner != 0 check - Remove "for testing" from UpdateFindingsForFile comment (production API) - Align filter logic with method documentation and behavior Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
cx-rakesh-kadu
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comprehensive Test Cases & Utilities
Files Changed (14 modified, 8 new)
Related Issue
AST-109633