Repository navigation
club import fix - #61
Closed
chipShot-exe wants to merge 1 commit into
Closed
chipShot-exe wants to merge 1 commit into
chipShot-exe wants to merge 1 commit into
Conversation
👷 Deploy request for lhsconnect pending review.Visit the deploys page to approve it
|
me-it-is
force-pushed
the
feat/club-import-fix
branch
from
November 7, 2026 21:17
c5cdd6f to
8cdcb8d
Compare
me-it-is
reviewed
Nov 7, 2026
me-it-is
left a comment
me-it-is
left a comment
Contributor
There was a problem hiding this comment.
More coming when i understand how this works
| </div> | ||
| </div> | ||
| <Checkbox bind:checked={overwriteCheckbox} id="overwrite"> | ||
| <span class="text-amber-500 dark:text-amber-600">Overwrite existing clubs</span> |
Contributor
There was a problem hiding this comment.
Amber looks good on light mode but it looks bad on darkmode. maybe a lighter color would work better for darkmode.
|
|
||
| let modalOpen = $state(false); | ||
|
|
||
| let overwriteCheckbox = $state(false); |
Contributor
There was a problem hiding this comment.
overwriteCheckbox sounds like you are over writing a checkbox overwriteClubs would be better
| @@ -84,7 +84,7 @@ https://lhs.cx/old-clubs | |||
| }, | |||
| complete() { | |||
| notificationContext.show('Imported ' + records.length + ' clubs', 'success'); | |||
Contributor
There was a problem hiding this comment.
This is no longer accurate to the amount of clubs that are actually imported
| } | ||
|
|
||
| let { data }: Props = $props(); | ||
| function handleImport( |
Contributor
There was a problem hiding this comment.
This function is never used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix club import so they don't overwrite by default. Replacement for #52 fix miscellaneous issues which is now closed.