Skip to content

Two of the earlier small tweaks from the R package - monitor log hazard ratio for boostrapping and print Hazard ratio#33

Merged
remlapmot merged 9 commits into
mainfrom
devel-1
Feb 6, 2026
Merged

Two of the earlier small tweaks from the R package - monitor log hazard ratio for boostrapping and print Hazard ratio#33
remlapmot merged 9 commits into
mainfrom
devel-1

Conversation

@remlapmot

Copy link
Copy Markdown
Contributor

This

  • Monitors the log hazard ratio instead of the hazard ratio due to better normality properties
  • Prints "Hazard ratio" instead of "Hazard" in two places
  • Bumps the version number.

@remlapmot remlapmot requested a review from ryan-odea February 5, 2026 15:03
@remlapmot

Copy link
Copy Markdown
Contributor Author

It seems the Python 3.10 tests have failed due to the recent requirement of the lifelines package for Python 3.11, so we seem to have 2 options:

  • either pin lifelines to the previous version which allowed 3.10
  • make Python 3.11 our min version

Don't test on Python 3.10
@remlapmot

remlapmot commented Feb 5, 2026

Copy link
Copy Markdown
Contributor Author

The 3.14 test passes on my local machine - just GHA being flaky I think

CleanShot 2026-02-05 at 16 32 47@2x

@ryan-odea

Copy link
Copy Markdown
Collaborator

It seems the Python 3.10 tests have failed due to the recent requirement of the lifelines package for Python 3.11, so we seem to have 2 options:

* either pin lifelines to the previous version which allowed 3.10

* make Python 3.11 our min version

I think it's good to make 3.11 our min version, I would only see more issues arise if we keep full support for previous versions.

@remlapmot

Copy link
Copy Markdown
Contributor Author

Hopefully ok - I'll merge this now before I do too much other fiddling (plus have limited time today)

@remlapmot remlapmot merged commit 727c14a into main Feb 6, 2026
4 of 8 checks passed
@ryan-odea ryan-odea deleted the devel-1 branch February 17, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants