Skip to content

IDE-101 Refactor CatroidApplication to kotlin#4925

Open
hannesweilharter wants to merge 17 commits into
Catrobat:developfrom
hannesweilharter:IDE-101
Open

IDE-101 Refactor CatroidApplication to kotlin#4925
hannesweilharter wants to merge 17 commits into
Catrobat:developfrom
hannesweilharter:IDE-101

Conversation

@hannesweilharter

@hannesweilharter hannesweilharter commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

Refactoring of class CatroidApplication to Kotlin

https://catrobat.atlassian.net/browse/IDE-101

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

Comment thread catroid/src/main/java/org/catrobat/catroid/CatroidApplication.kt Fixed
Comment thread catroid/src/main/java/org/catrobat/catroid/CatroidApplication.kt Fixed
Comment thread catroid/src/main/java/org/catrobat/catroid/CatroidApplication.kt Fixed
Comment thread catroid/src/main/java/org/catrobat/catroid/CatroidApplication.kt Fixed
Comment thread catroid/src/main/java/org/catrobat/catroid/CatroidApplication.kt Fixed
Comment thread catroid/src/main/java/org/catrobat/catroid/ui/BaseActivity.kt Fixed
@harshsomankar123-tech harshsomankar123-tech self-requested a review May 11, 2026 14:57

@harshsomankar123-tech harshsomankar123-tech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hannesweilharter Sorry for the delay, I’ve been busy with refactoring work. I reviewed the changes and found some bugs, otherwise LGTM.

Comment thread catroid/src/main/java/org/catrobat/catroid/CatroidApplication.kt Outdated
Comment thread catroid/src/main/java/org/catrobat/catroid/ui/BaseActivity.kt Outdated
Comment thread catroid/src/main/java/org/catrobat/catroid/CatroidApplication.kt
@harshsomankar123-tech harshsomankar123-tech added the Active Member Tickets that are assigned to members that are still currently active label May 15, 2026
@sonarqubecloud

Copy link
Copy Markdown

Comment thread catroid/src/main/java/org/catrobat/catroid/CatroidApplication.kt Dismissed

@harshsomankar123-tech harshsomankar123-tech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hannesweilharter Thanks! Looks Good @reichli PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Active Member Tickets that are assigned to members that are still currently active

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants