Conversation
vincent-botbol
left a comment
There was a problem hiding this comment.
In this current state, it doesn't work properly in the extension. The path is relative to the project's root which is not necessarily our cwd when we are in VScode, hence the links are broken. Perhaps, the extension could do some work on its side but, for resilience sake, I think it's best to leave this path as absolute.
This adds a special "inline mode" for clerk targets, that will run `catala` directly from the project root, with its stdlib pointing to its installed directory rather than `_build/libcatala`. This mode assumes that the run command does not write any files.
|
I am still not convinced by absolute paths (although it certainly is the fastest reliable fix in this case) ; but you actually point to an issue outside of this consideration: when running Do you think that fixing this would solve your issue in any way, or is it unrelated ? |
rather than the repository root. Also affects the json_schema command.
|
I fixed that, and according to my tests that fixed it in the extension as well, @vincent-botbol what do you think ? |
This relaxes the need to run ninja by fine-tuning the args needed by Catala.
NOTE: I removed the
make_absolutefrom the JSON printing -- the relative path is now correct -- but the result in VScode should be checked for surprisesAlso: adds a missing mli and hyperlinks (you can now click the conditions in the trace in terminal output)