Conversation
AltGr
changed the title
denismerigoux
approved these changes
Jun 4, 2026
and some fixes to the JSON output of the OCaml backend as well
The Encoding module will still be useful when we want to handle deserialisation: we'll need to: - tweak it to work with runtime types instead of compiler types - move it to the runtime (and add yojson to the runtime links, but it's fairly small with no extra deps; better than recoding our own parser with bugs and bad error handling)
Contributor
Author
|
Ah, that's annoying: CI fails in closure-conversion mode because of: Testing the interpreter / OCaml backend in closure conversion mode is hackish anyway¹... a nice validation while we could get it passing, but it might be time to disable it from CI if it's becoming more of a burden.
¹ the interpreter dynamically detects if it has a closure instead of a function for application, and some other tweaks; but the runtime operators are still not designed to take closures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, this just implement JSON output in the Python backend and fixes some small things in the OCaml one
NOTE: stacked on top of #1031