Draft: A backend for each file instead of having a enabled backends for all#1023
Draft
Arnaud-Bihan wants to merge 6 commits into
Draft
Draft: A backend for each file instead of having a enabled backends for all#1023Arnaud-Bihan wants to merge 6 commits into
Arnaud-Bihan wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating the clerk.ninja file to execute commands, clerk_rules retrieve the enabled backend by concatenation of all possible bakcends for all backends.
But this lead to an issue on external file for example, if I create a target A in OCaml with an external file (written in OCaml) and a target B in Java, Clerk will expect my external file from the target A to have an implementation in Java because the enabled_backends are OCaml and Java for all the files.
This is an attempt not finished to fix that (this is clearly not optimal the way I did it for now)