Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/roadmap.md
Original file line number Diff line number Diff line change
Expand Up @@ -1430,6 +1430,9 @@ principles named were durable, accurate and reactive. Found in rally 0x7 by plus
run alongside; observed only, never changing the result; the browser tests carry those lines to their own
standard error, so ci-local's log has them; with tests for a segfault retried, a second failing, and a teardown
crash with a stand-in coredumpctl.
- [ ] **RAL-184: The digest's gate line counts "suites and scenes".** From the watchman's read of RAL-181: with every
suite recorded, RAL-180's green line said "112 scenes" of what are mostly the QUICK phase's suites. Done when: the
line, and the parser's and service's bound messages, say "suites and scenes"; with the tests updated.
- [ ] **RAL-182: The state-bar redraw test waits on what it reads, not on fixed times.** From the watchman
(2026-11-14): `a_redraw_moves_the_state_bar_with_the_counts` failed once under full-suite load for jaunty-harrier
(at `in_browser`'s check that the script ended well; its output wasn't kept, and no Chrome core was dumped
Expand Down
4 changes: 2 additions & 2 deletions src/digest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1524,7 +1524,7 @@ mod tests {
"a" | "b" => Verdict::Green {
tip: tip.clone(),
on_main: true,
summary: "QUICK OK, 3 scenes, 0 failed".into(),
summary: "QUICK OK, 112 suites and scenes, 0 failed".into(),
},
"c" => Verdict::Running {
tip: "2".repeat(40),
Expand Down Expand Up @@ -1560,7 +1560,7 @@ mod tests {
[
"- DSM-1, DSM-2: landed in 1111111: gated locally, green at 1111111 [observed: \
~/.local/state/dsm-gates/1111111111111111111111111111111111111111.log names \
1111111 (QUICK OK, 3 scenes, 0 failed), its .ok is there, and git shows 1111111 \
1111111 (QUICK OK, 112 suites and scenes, 0 failed), its .ok is there, and git shows 1111111 \
on origin/main in ~/Documents/GitHub/Discoteque and holding each]",
"- DSM-3: gate running at 2222222 for 50 min [observed: \
~/.local/state/dsm-gates/2222222222222222222222222222222222222222.log, no .ok \
Expand Down
4 changes: 2 additions & 2 deletions src/gate_check.rs
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ fn green(log: &GateLog, tip: &str) -> Result<String, String> {
}
match log.failures() {
(0, 0) => Ok(format!(
"{}{} scenes, 0 failed",
"{}{} suites and scenes, 0 failed",
log.quick
.as_deref()
.map(|q| format!("{q}, "))
Expand Down Expand Up @@ -398,7 +398,7 @@ mod tests {
Verdict::Green {
tip: tip.clone(),
on_main: true,
summary: "QUICK OK, 1 scenes, 0 failed".into()
summary: "QUICK OK, 1 suites and scenes, 0 failed".into()
}
);
}
Expand Down
4 changes: 3 additions & 1 deletion src/gate_log.rs
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,9 @@ pub fn parse(text: &str, path: &str, sha256: &str, bytes: u64) -> Result<GateLog
scenes.retain(|s| s.passed.is_some());
} else if let Some(scene) = suite_header(line) {
if scenes.len() >= MAX_SCENES {
return Err(format!("the log has more than {MAX_SCENES} scenes"));
return Err(format!(
"the log has more than {MAX_SCENES} suites and scenes"
));
}
scenes.push(Scene {
scene: scene.chars().take(120).collect(),
Expand Down
2 changes: 1 addition & 1 deletion src/ledger.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3867,7 +3867,7 @@ fn check_fields(change: &Change) -> Result<(), LedgerError> {
}
if log.scenes.len() > crate::gate_log::MAX_SCENES {
return Err(LedgerError::InvalidChange(format!(
"a gate log records at most {} scenes",
"a gate log records at most {} suites and scenes",
crate::gate_log::MAX_SCENES
)));
}
Expand Down
Loading