Repository navigation
RAL-183: browser tests forward only real crash lines, marked as real - #270
Merged
Merged
Conversation
The lamplighter read RAL-179's own faked teardown crash in ci-local's log as a real one. run_browser now forwards nothing from a run with a stand-in Chrome command or coredumpctl; a real run's lines begin "browser test: [real Chrome, real coredumpctl]"; the stand-in core's time and pid are impossible ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sh's, by time The lamplighter's real abort of 12:05:52Z was listed by two runs, each as not theirs: a crash at start is gone before a pid of it can be taken. A core within 2 s of the run's own crash at start is now said as that one's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RAL-183, assigned by the watchman, after the lamplighter read RAL-179's own faked teardown crash in ci-local's log (61d0dca check.log 738–739) as a real one.
run_browserwrites nothing to the test's own stderr from a run whose Chrome command isn't the realRALLY_TEST_CHROME, or that uses the stand-in coredumpctl. The tests that fake a crash still assert on the script's output. This covers RAL-160's forwarded retry as well, whose fake-zypak lines reached the log the same way.browser test: [real Chrome, real coredumpctl]. A forwarded retry says "crashed" or "aborted" by its status.🤖 Generated with Claude Code