Repository navigation
RAL-182: the state-bar redraw test waits on what it reads, not on fixed times - #269
Merged
Merged
Conversation
…ed times From the watchman: a_redraw_moves_the_state_bar_with_the_counts failed once under load. Its probe went on without the board after 10 s, read widths after a fixed 1 s while a 0.6 s transition could still be running on a starved timeline, and could be redrawn by the page's own 30 s poll. It now waits for the first draw (20 s, said if missing), for the bar's transitions to finish, and draws again after a poll. With the style update removed it still fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RAL-182, from the watchman:
a_redraw_moves_the_state_bar_with_the_countsfailed once for jaunty-harrier under full-suite load.What the failure was: it failed at
in_browser'sassert!(ok)(tests/web.rs:1102 at 90de3d3), so the script ended badly, not one of the probe's assertions. Its output wasn't kept, so the exact error can't be named. No Chrome core was dumped between 05:30 and 05:50, and ci-local's logs have never shown this test failing alone.The test's own timing assumptions, fixed (the timeouts are unchanged):
getAnimations(), so it reads only once the transitions have finished.redrawnByPoll.Checked:
🤖 Generated with Claude Code