Repository navigation
RAL-181: batch end --gate-log records every suite, the QUICK phase's too - #268
Merged
Merged
Conversation
…s too The gate log parser counted only the three `== res://tests/<scene>.tscn ==` scenes of about 112 suites in today's dsm-gate logs. Each `== <suite> ==` or `== <suite> (what it covers) ==` header is now recorded by name with its `=== N passed, M failed ===` counts (a trailing `, K skipped` reads too). A QUICK suite with no count line, the bench, judged by its own verdict suite, is covered by the gate's QUICK OK and left out; without a QUICK OK it's kept as giving no result. The bound is 256 (the service checks it too, so CLI and service go together). Every new-format log on Murph with a .ok reads green: 6 of 6, up to 112 suites. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RAL-181, the watchman's (c) after RAL-180.
gate_log::parseread only the three== res://tests/<scene>.tscn ==scenes. Today's dsm-gate logs have about 112 suites.== <suite> ==or== <suite> (what it covers) ==header is recorded by name, with its=== N passed, M failed ===counts.=== … ===result lines are never mistaken for headers, and a heading with words isn't a suite., K skippedcount is accepted (test_club_navwrites it).QUICK OKcovers it. Without aQUICK OK, such a suite is kept as giving no result.MAX_SCENESgoes from 64 to 256. The service checks that bound on append, so a CLI from this build needs a service from this build to record a full log. The live service (475bd94) has no batch records at all yet: RAL-157 and RAL-162 aren't in it. So the CLI and service go out together at the restart.Test:
every_suite_is_recorded_the_quick_phases_too(suites, descriptions, skipped, the bench with and without QUICK OK).Checked on Murph: every new-format log in
~/.local/state/dsm-gatesthat has a.okreads green: 6 of 6, up to 112 suites. The other 215 logs predate the first line and are refused as before. The first pass foundtest_club_nav(skipped count) andbench(no count) reading as failing, which is what led to the two rules above.Docs: docs/brief.md and the roadmap. fmt, clippy -D warnings, and
cargo test --locked --no-fail-fastall pass locally. Queued behind #266 and #267.🤖 Generated with Claude Code