Repository navigation
fix(shim): a messages read right after connecting waits for registration (MUS-114) - #199
Merged
Merged
Conversation
…ion (MUS-114) The restart-file e2e failed intermittently in CI (#185, #194) and in 2 of 15 local runs: a fresh shim's muster://messages read was refused as unregistered before its Session SET landed. Tool calls already held for registration and retried once on that refusal (MUS-72, MUS-79); the read did neither. Both now go through as_registered. 0 of 30 local runs failed with the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s-for-registration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
scripts/test-restart-file-e2e.shfailed intermittently: on #185 at 255b343, on #194 at 18a1dd7 (neither diff touches it), and in 2 of 15 local runs at #185's head. With a copy of the script that prints the error the script normally throws away, the daemon's answer to the member'smuster://messages?inbox=true&unread=trueread was:A fresh shim read before its Session SET landed. The test's readiness loop passed early because
is_selfmatched the session's row from the previous shim run, which has the same id and a dead connection. Tool calls already hold for registration and retry once on this refusal (MUS-72, MUS-79). The messages read did neither. A real agent reading its inbox right after a restart could hit the same refusal.What
call_toolintoas_registered, and themessagesresource uses it too. The tool path behaves the same.Checked
cargo test -p muster-shim --bins: 151 passed.cargo clippy -p muster-shim --all-targets -D warnings: clean.Not covered
as_registered, because it needs aToolHostand a live client. The e2e is the regression test.🤖 Generated with Claude Code