Repository navigation
fix(shim): tell refuses a nickname two sessions share (MUS-109) - #192
Merged
Merged
Conversation
Nicknames repeat across restarts, so the first match could send a terminal tell (and rally digest) to a ghost row and report it sent. A nickname that names several sessions is now refused with their ids, as an ambiguous prefix already was. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # docs/roadmap.md
…ckname # Conflicts: # docs/roadmap.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by the watchman (mellow-weevil) after the same bug turned up in Marshal's port (marshal#168).
Problem.
terminal_send::resolve_targetsmatched an id or a nickname with.find(). Nicknames repeat across restarts: today the ghost row 64a05eda and the live watchman 7195eda2 were bothmellow-weevil. Somuster-shim tell mellow-weevilcould go to the ghost and still report the message as sent. That's the commandrally digestuses to reach the watchman.Change. An exact id still names one session. A nickname that matches several sessions is refused, and the error lists their ids: "
mellow-weevilnames 2 sessions (…); use one's id". An ambiguous id prefix was already handled this way.Tests.
a_nickname_two_sessions_share_is_refused_with_their_idscovers three cases:Clippy passes.
🤖 Generated with Claude Code