Repository navigation
Test the local idle deadline and bound import thinning - #33
Merged
Merged
Conversation
Silence from an unplugged receiver must end a track through the deadline in run(), which nothing tested. Import thinning had no lower bound, so keeping only the ends passed. Also updates a test label now that a crossing inside road_heading is settled as known. Story: CHOMP-3 Story: CHOMP-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A stall could let the deadline beat queued fixes and drop the track the test was following. The car now never moves, so every track is dropped, and the test waits for all of them to go. Story: CHOMP-3 Story: CHOMP-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the two limits left open after #30. Test code only.
silence_ends_the_track_at_the_deadline: runs the realrun()loop with a car that never moves, then goes silent. Every track must end and, being too short to keep, be removed. That a long track is kept when finished is covered by the repeat-route test.gpx_round_trip_and_health: no gap between kept points of the 60-second drive may exceed 25 s. At this speed a fix is due about every 20 s.known_road_querycase for a crossing insideroad_heading, which is now settled.Evidence, run locally on
imresamu/postgis:17-3.5-bookworm: all 4 ignored tests pass, and each mutation fails only the intended check.thin()keeps only the endsrun()disabledThe deadline test uses real time (
track_idle0.5 s, 10 s timeout). After review found a stall could fail the first version, it passed 20 of 20 with a 600 ms sleep injected instart_track, and 20 of 20 without. A stall of over 10 s could still fail it. The 25 s bound depends on the default beacon parameters, so changing those may need it updated.Neither story finishes here: CHOMP-3 still needs a real TNC, and CHOMP-5 still needs the update upload on the reTerminal.
Story: CHOMP-3
Story: CHOMP-5
🤖 Generated with Claude Code