fix(sql-workbench): use ConfirmDialog for Drop instead of window.confirm#32
Merged
Merged
Conversation
Replaces the window.confirm() gate in the Drop flow with the shared <ConfirmDialog> (CLAUDE.md rule #3). The Drop button opens a dialog; the drop runs on confirm via doDrop(). A pending drop confirm is also discarded on a BU switch, matching the destructive-run confirm. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fast-follow จาก PR #31 — แทน
window.confirm()ใน Drop flow ด้วย<ConfirmDialog>ตาม CLAUDE.md rule #3 (ห้ามwindow.confirm).window.confirm· renamehandleDrop→doDrop(drop logic ล้วน)setDropConfirm(true)); drop รันเมื่อ confirm ผ่านdoDropconfirmVariant="destructive", confirmText "Drop"; description โชว์schema.name+ tenant + "cannot be undone"window.confirmในsrc/pages/sqlWorkbench/Test plan
dropObject('T02', {view public.v_test})ถูกเรียกtsc --noEmitclean🤖 Generated with Claude Code