Repository navigation
fix(thread): hide and show the app bar after the list travelled some way - #250
Merged
Merged
Conversation
The app bar of the thread page followed the direction every drag started in, so a touch screen that loses and finds the finger again a few pixels away (or a wobbling thumb) pulled the bar out and in at every turn. Now the list has to travel 56 logical pixels in one direction since it last turned before the bar hides (down the list) or shows (up); a turn starts the travel over. The top of the list still shows the bar at once, a list that scrolls no farther than the bar still keeps it, and only the list itself (depth 0, vertical) counts, as before. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題
朋友回報(Telegram):帖子頁往下捲時頂欄收進去、往上捲時彈出來,手機觸控有點斷觸時就反覆抽搐——現在只要有一點上翻的跡象就彈出。
原因
AppBarCollapser照每次拖曳開始時的方向(UserScrollNotification.direction)立刻收或展,靈敏度等於 0 px。修正
測試
test/regression/test_265_app_bar_scroll_threshold_test.dart(9 項):拖曳方向不再觸發、門檻前後、來回幾 px 不動、轉向重計、頂端必顯示、短列表保留、橫向不算、關閉設定。test_239_ux_small_fixes_test.dart(含原本 L5 收展測試)61 項全過。CHANGELOG 照慣例發版時再補。
🤖 Generated with Claude Code