Primary Cesium Addition to Geoview#2860
Conversation
Removed script tag in HTML docs Imported Cesium in ts Updated webpack to allow for proper integration of cesium build Added cesium package to rush/package.json
Zooming to 2D extents when opening 3D, and the reverse.
Changed scale formatting to apply more consistent rules Included m and ft to scales Fixed issue with pointerposition being null during 2d-3d map changes
Added support for mouse position
Expose the Cesium viewer for use with Geoview controls
Added the ability to toggle visibility in 3D with the geoview legend controls. This commit supports only individual layer toggling and not layer group toggling.
|
@joshahussey Hi, I sent you an invite to our repo so you can host your PR. This way I will be able to test your code live. |
jolevesq
left a comment
jolevesq
left a comment
There was a problem hiding this comment.
Reviewed 12 of 14 files at r1, 5 of 6 files at r2, all commit messages.
Reviewable status: 17 of 18 files reviewed, 2 unresolved discussions
packages/geoview-core/public/index.html line 12 at r2 (raw file):
<body> <script src="https://cesium.com/downloads/cesiumjs/releases/1.113/Build/Cesium/Cesium.js"></script>
Why do we need this script tag?
packages/geoview-core/webpack.common.js line 215 at r2 (raw file):
to: 'cesium/Workers', }, // {
Do we need this code in comments?
STAC Browser In GeoView when 3D gets opened
joshahussey
left a comment
joshahussey
left a comment
There was a problem hiding this comment.
Thank you, I will find the email and accept ASAP.
Reviewable status: 14 of 28 files reviewed, 2 unresolved discussions (waiting on @jolevesq)
packages/geoview-core/webpack.common.js line 215 at r2 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Do we need this code in comments?
No, it does not you're correct. We had to implement a patch in Cesium to address a bug related to imagery layers in their source code. This comment is there as we are in the midst of reworking the webpack config in order to accomodate the local cesium build, the final version of the webpack config will contain no comments. Thank you!
packages/geoview-core/public/index.html line 12 at r2 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Why do we need this script tag?
We do not. You are correct. I just removed it, thank you.
|
@joshahussey Can you go to https://github.com/orgs/Canadian-Geospatial-Platform/people?query=josh then set your profile as public. This way you will be able to do rush build then rush host and your demo page will be available for us to test. Thanks |
* feat(ui): Selector palceholders for STAC Browsers * feat(ui): Listeners for onLayerAdded and onLayerRemoved events in Cesium
Done. I will run rush host shortly. We merged upstream changes and introduced some issues with panel sizing that needed to be addressed. |
* Clicking navbar home button with 3d map open will return 3d to default view extents.
* Connect the zoom in/out buttons to work with cesium when the 3D map is open
* Fix to allow visibility toggle in the legend to toggle visibility for multiple layers at once in 3d.
* Prevent a user from zooming out so far that the globe is unrendered.
* Connect STAC to geoview notification system.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
3 participants
Description
Cesium was added to Geoview.
Styling of certain layers and support for certain layers unfinished.
STAC Catalog not yet added.
Fixes # (issue)
Type of change
How Has This Been Tested?
Tested locally using Rush Serve. Tested on many different demo pages.
https://joshahussey.github.io/geoview/add-layers.html
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is