Add libby client library#17
Open
mikelangmayr wants to merge 6 commits into
Open
Conversation
mikelangmayr
commented
Jun 1, 2026
mikelangmayr
commented
Collaborator
- consolidate config file loading
- extract shared core modules and use them across cli and client lib
- use custom errors
- add documentations
prkrtg
reviewed
Jun 2, 2026
| self.topics: Dict[str, EvtHandler] = dict(getattr(type(self), "topics", {})) | ||
|
|
||
| @classmethod | ||
| def from_config(cls, cfg: Dict[str, Any]) -> "LibbyDaemon": |
Collaborator
There was a problem hiding this comment.
Should this also include transport and group id?
Collaborator
Author
There was a problem hiding this comment.
The libby daemon is a bit out of date, hispec daemon is the one with the latest changes. Let's have a chat about the role of the libby daemon template vs the hispec daemon template
| """ | ||
| if value == "": | ||
| return None | ||
| low = value.strip().lower() |
Collaborator
There was a problem hiding this comment.
Should we start a lookup table for fixed string values as this grows?
Collaborator
Author
There was a problem hiding this comment.
Not sure how you would implement this, the Rabbit broker in some ways is a lookup table already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.