Repository navigation
fix(control): prefer real Linux and macOS LAN interfaces - #737
Merged
Merged
Conversation
Wi-Fi names such as wlp3s0 were losing to a Docker veth, and OpenVPN matched the old "en" fragment. Linux and macOS keep UDP 9000, 9001, and mDNS 5353. When 5353 is privileged or already held, the announcement still leaves and IPv4 OSC input keeps listening. Co-authored-by: caganturgut <271973834+caganturgut@users.noreply.github.com>
|
CaYaDraft — pull request Summary Files
Note Stopping here. I will not merge, push, or change this pull request until you ask.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wlp*/wlan*and macOSen0over Dockerveth,utun, and a VPN whose name merely contains the letters "en".Tests
npm test: 2980 pass, exit 0.wlp3s0overvethanddocker0), macOS (en0overutun0andbridge100), andenp0s3overOpenVPN.Co-authored-by: caganturgut 271973834+caganturgut@users.noreply.github.com