Skip to content

feat(control): name OSC input and leave a crowded OSCQuery port - #736

Merged
CaYatur merged 2 commits into
mainfrom
feat/osc-input-card
Oct 11, 2026
Merged

CaYatur merged 2 commits into
mainfrom
feat/osc-input-card

Conversation

@CaYatur

@CaYatur CaYatur commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • The Control card for incoming OSC is named OSC Girişi (OSC Input). OSC Çıkışı stays the output card.
  • UDP 9000, UDP 9001, and mDNS 5353 stay. Those are the OSC pair and the IANA mDNS port. If 5353 cannot be shared, an ephemeral socket still announces the service.
  • OSCQuery has no standard port. The default moves from 9010 to 17801 because other programs (Logitech G HUB on this machine) answer 127.0.0.1:9010 while a wildcard listener looks open. If localhost on the chosen port is not this app, the server moves to a free port, the panel shows it, and the setting is saved.
  • HOST_INFO skips virtual adapters such as VirtualBox host-only and prefers Wi-Fi or Ethernet.

Tests

  • tests/osc-in.test.js: a free OSCQuery port stays put; a localhost listener that is not SoundVisualizer forces a move and the original port still answers the other program; virtual adapters lose to a physical LAN address, including numeric family: 4; ports 9000, 9001, 5353, and 38471 are not OSCQuery candidates; mDNS must either bind 5353 or announce.
  • Local node --test tests/osc-in.test.js: 13 pass.
  • npm test: 2980 pass. The badge claim is part of that command.
  • npm run smoke on an isolated profile is the other merge gate.

Co-authored-by on the commit: caganturgut. CaYatur is the commit author and already the repository owner.

CaYatur and others added 2 commits October 11, 2026 21:23
The input card is OSC Girişi. UDP 9000, UDP 9001, and mDNS 5353 stay.
OSCQuery defaults to 17801 and moves when localhost belongs to another
program. HOST_INFO prefers a physical LAN address over a virtual adapter.

Co-authored-by: caganturgut <271973834+caganturgut@users.noreply.github.com>
The OSCQuery localhost check added one test. The badge claim
compares the suite total, so 2979 failed the gate.

Co-authored-by: caganturgut <271973834+caganturgut@users.noreply.github.com>
@CaYatur

CaYatur commented Oct 11, 2026

Copy link
Copy Markdown
Owner Author

Local npm test: 2980 pass, exit 0. Isolated npm run smoke RESULT: PASS (camera NotAllowedError is the usual smoke refusal). GitHub Actions syntax plus unit tests on Ubuntu and Windows, Node 20 and 22, all passed. Merging.

@CaYatur
CaYatur merged commit f6b0117 into main Oct 11, 2026
5 checks passed
@CaYatur
CaYatur deleted the feat/osc-input-card branch October 11, 2026 18:25
@cayadraft

cayadraft Bot commented Oct 11, 2026

Copy link
Copy Markdown

@CaYatur

CaYaDraft — pull request

Summary
This pull request renames the incoming OSC control card to "OSC Girişi" (OSC Input) and changes the default OSCQuery port from 9010 to 17801 to avoid conflicts with other services like Logitech G HUB. It also adds logic to detect virtual network adapters and skip them when selecting a LAN address for the query port, while ensuring reserved ports remain available for other functions.

Files

  • README.md (and .tr.md): Documentation updates regarding the new default port and service behavior.
  • src/admin/admin.js & control.js: UI title changes to reflect "OSC Input".
  • src/main/osc-query.js: Core logic for detecting LAN addresses, handling virtual adapters, and managing query port selection.
  • src/shared/defaults.js: Updated default configuration values.
  • tests/osc-in.test.js: Added tests for port conflict detection and virtual adapter exclusion.

Note
Nothing blocking is visible from the text.


Stopping here. I will not merge, push, or change this pull request until you ask.

/caya explain describes the diff. /caya plan previews the next edit. /caya revise adds a commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant