[CBRD-26985] Fix OOS copyarea lock fetch crash#7368
Draft
vimkim wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
/run sql medium |
7a30859 to
2fe42bd
Compare
Contributor
Author
|
/run sql medium |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.cubrid.org/browse/CBRD-26985
Purpose
recdes.data를 scan cache 로 rebind 해도,LC_COPYAREAdescriptor 는 항상 copyarea 내부 bytes 를 가리키게 한다.Implementation
locator_copyarea_prepare_fetch_recdes로 다음 object 가 사용할 copyarea slot 과 남은 payload 크기를 계산하고, fetch 직전에recdes.data/recdes.area_size를 그 slot 으로 맞춘다.locator_copyarea_pack_fetch_recdes로 fetch 결과가 현재 slot 에 들어가는지 확인하고,recdes.data가 scan cache 등 copyarea 밖이면 descriptor publish 전에 copyarea 로 복사한다.xlocator_lock_and_fetch_all:ALTER TABLE ... CHANGEdomain upgrade crash 재현 경로xlocator_fetch_all:unloaddb/compactdb등 bulk fetch sibling 경로S_DOESNT_FITgrow/retry 흐름을 유지하고, 이미 읽은 OID 는 retry 전에 되돌린다.Verification
git diff --checklocator_sr.csingle-file compile:SERVER_MODElocator_sr.csingle-file compile:SA_MODEfunction_index_skip_bit.sql도 새 core 없이 통과했다.Remarks
OOS+REC_BIGONEabort 는 별도 문제다. 이 PR 은 copyarea packing 계약만 고친다.