fix: add missing <string> include to Types.hpp#59
Open
aki1770-del wants to merge 1 commit into
Open
Conversation
GCC 14 tightened transitive include enforcement. std::string is used directly in Types.hpp (ConnectionId_t typedef and ClientId::getEnv/getHostAddress return types) but was only reachable through transitive includes from other headers. Add explicit #include <string> to make the dependency self-contained and fix compilation under GCC 14 strict mode. Fixes COVESA#47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GCC 14 tightened enforcement of transitive includes.
std::stringis used directly inTypes.hpp(asConnectionId_ttypedef and as the return type ofClientId::getEnv()andClientId::getHostAddress()) but was not explicitly included — it was only reachable through transitive pulls from other headers.This causes build failures when consumers compile with
-includeprecompiled headers or when GCC 14's stricter diagnostics are enabled.Reported in #47.
Fix
Add
#include <string>explicitly inTypes.hpp.Testing