Skip to content

Lalit card#90

Open
9389lalit wants to merge 3 commits into
COPS-CSOC-2022:mainfrom
9389lalit:Lalit-card
Open

Lalit card#90
9389lalit wants to merge 3 commits into
COPS-CSOC-2022:mainfrom
9389lalit:Lalit-card

Conversation

@9389lalit

Copy link
Copy Markdown

Roll no-21095068
Name:-Lalit Singh
Branch:- Electronics
Github handle:-lalit9389

@vercel

vercel Bot commented May 30, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
csoc-22-week0-namecards ✅ Ready (Inspect) Visit Preview May 30, 2022 at 5:34PM (UTC)
csoc-week0-namecards ✅ Ready (Inspect) Visit Preview May 30, 2022 at 5:34PM (UTC)

@9389lalit

Copy link
Copy Markdown
Author

Lalit singh from Electronics engineering

@9389lalit

Copy link
Copy Markdown
Author

Lalit singh from Electronics engineering

@debarati-06 debarati-06 self-requested a review June 5, 2022 17:35
Comment thread utils/contributors.js
</div>
`,
github: "https://github.com/ankur12-1610",
github: "https://github.com/lalit9389",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only have to add your card and not edit the sample ones.

Comment thread utils/contributors.js
{
handle_name: 'lalit9389',
name: "Lalit Singh",
image: "anime.jpg",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image file path is incorrect.

Comment thread utils/contributors.js
<lord-icon src="https://cdn.lordicon.com/jpdtnwas.json" trigger="loop" colors="primary:#121331,secondary:#e88c30" style="width:25px;height:25px"></lord-icon>
</div>
`,
github: "https://github.com/lalit9389",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your GitHub link is non-functional. Provide correct links or you may skip it.

@debarati-06 debarati-06 added the pending changes requested changes in the pull request label Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending changes requested changes in the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants