Add public set_alignment_scope setter#3
Open
cjfields wants to merge 1 commit into
Open
Conversation
The `alignment_scope` field is public, but configuring it required setting the field directly; the other alignment-configuration knobs (`set_max_alignment_steps`, `set_alignment_free_ends`) are exposed as methods. Add a matching `set_alignment_scope` so callers can switch on CIGAR computation (`ComputeAlignment`) through the same method-based API. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Just a small comment, this isn't a high priority PR since there is a noted work-around, just a nice-to-have so it's consistent with the other setters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
set_alignment_scopemethod toWavefrontAligner, matching the existing method-based configuration API (set_max_alignment_steps,set_alignment_free_ends).Why
The
alignment_scopefield is public, but switching on full-CIGAR computation currently requires writing the field directly:while the other alignment-configuration knobs are exposed as setters. This adds the matching method so callers can opt into CIGAR output (
ComputeAlignment) through the same idiom:Notes
Small, additive change (one method); no behavior change. Encountered while embedding the library as a pairwise aligner — the default scope is
ComputeScore, so a setter makes the "I also want the CIGAR" path discoverable.