Skip to content

Remove eoscale urbanmask#61

Merged
namsellem merged 8 commits into
remove_eoscalefrom
remove_eoscale_urbanmask
Mar 17, 2026
Merged

Remove eoscale urbanmask#61
namsellem merged 8 commits into
remove_eoscalefrom
remove_eoscale_urbanmask

Conversation

@namsellem

Copy link
Copy Markdown
Collaborator

Removing module eoscale from urbanmask steps

refers to #49

  • Fix watermask aux files handling (silent error)
  • Remove eoscale and replace it with eomultiprocessing processors

This PR Closes #49

@namsellem namsellem requested a review from ytanguy March 16, 2026 10:23
@namsellem

namsellem commented Mar 16, 2026

Copy link
Copy Markdown
Collaborator Author

CI Fail

  • Reduce McCabe complexity in mp_n_to_m_images processor
mp_n_to_m_images
│
├── validation
├── singleprocess runner
├── in-memory runner
├── streaming runner
└── utilities

@ytanguy

ytanguy commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator

Thanks @namsellem for this PR.
Could you please check the coverage, by running validation / features tests with pycov ?

I've also a (small !) remark : I suggest to rename "phr_band_x" into "vhr_band_x" parameters (in urban/watermask, etc.) because this would refer to Very High Resolution instead of Pleiades...

After this, you can merge this PR.

@namsellem

Copy link
Copy Markdown
Collaborator Author

Features & Validation coverage Report

Name                                        Stmts   Miss  Cover
---------------------------------------------------------------
slurp/__init__.py                               7      0   100%
slurp/eomultiprocessing/__init__.py             0      0   100%
slurp/eomultiprocessing/slurp_executor.py     188    124    34%
slurp/eomultiprocessing/slurp_manager.py       46     16    65%
slurp/eomultiprocessing/utils.py               43     17    60%
slurp/masks/__init__.py                         7      0   100%
slurp/masks/shadowmask.py                     127     29    77%
slurp/masks/stack_masks.py                    230     88    62%
slurp/masks/urbanmask.py                      265     32    88%
slurp/masks/vegetationmask.py                 354     60    83%
slurp/masks/watermask.py                      360     32    91%
slurp/post_process/__init__.py                  0      0   100%
slurp/post_process/morphology.py               32     13    59%
slurp/prepare/__init__.py                       7      0   100%
slurp/prepare/analyse_glcm.py                  73      9    88%
slurp/prepare/aux_files.py                      7      0   100%
slurp/prepare/geometry.py                     110      2    98%
slurp/prepare/prepare.py                      227     29    87%
slurp/prepare/primitives.py                    29      0   100%
slurp/prepare/validity.py                      10      2    80%
slurp/tools/__init__.py                         7      0   100%
slurp/tools/constant.py                         7      0   100%
slurp/tools/eoscale_utils.py                   80     43    46%
slurp/tools/io_utils.py                        30      7    77%
slurp/tools/misc.py                            26     26     0%
slurp/tools/mylogger.py                        27     14    48%
slurp/tools/profile_utils.py                   78     29    63%
slurp/tools/pydantic_class.py                 144      0   100%
slurp/tools/random_forest_utils.py             23      0   100%
slurp/tools/utils.py                           56      7    88%
---------------------------------------------------------------
TOTAL                                        2600    579    78%

@namsellem

Copy link
Copy Markdown
Collaborator Author

@ytanguy Thanks for your feedback. I swapped the vhr/phr variable names and generated the coverage report.
I think we can avoid considering eomultiprocessing coverage for now, as this component might become an external one.

@ytanguy

ytanguy commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator

@ytanguy Thanks for your feedback. I swapped the vhr/phr variable names and generated the coverage report. I think we can avoid considering eomultiprocessing coverage for now, as this component might become an external one.

Thanks ! Can you also swap the vhr/phr variable in watermask.py ?

After that we shall close this PR.

@namsellem namsellem merged commit bb2d31f into remove_eoscale Mar 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants