Repository navigation
fix(dotnet): run the audit task under posix sh - #84
Merged
Merged
Conversation
mise runs toml tasks with sh (dash), which rejects `set -o pipefail`, so the audit task errored at "Illegal option -o pipefail" the first time a consumer ran it. Foundry's own CI has no .NET project, so it never exercised the task. The capture `out=$(...) || exit 1` already fails loud on a dotnet list error, so plain `set -eu` keeps the safety and runs everywhere.
CMaintz
force-pushed
the
fix/dotnet-audit-posix-shell
branch
from
October 9, 2026 11:52
1722268 to
915161a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dotnet
auditmise task usedset -euo pipefail, but mise runs toml tasks undersh(dash), which rejectspipefail(sh: set: Illegal option -o pipefail). It surfaced the first time a consumer actually ranmise run audit(jev-dotnet adopting the dotnet stack); Foundry's own CI has no .NET project, so the task was never exercised here.set -euruns under both sh and bash. The explicitout=$(dotnet list ...) || exit 1capture is what fails loud on adotnet listerror, not pipefail, so the audit keeps its teeth.