Repository navigation
feat(dotnet): scope the SonarAnalyzer reference to the sensor build - #82
Merged
Merged
Conversation
Load SonarAnalyzer only when CodeAnalysisRuleSet is set, so typecheck (dotnet build -warnaserror, no ruleset) never loads it. The habit-hooks dotnet sensor sets the ruleset, so it still gets the structural rules and ratchets them. This keeps the preset safe in a strict repo that drops the bulk suggestion line, where an unconditional reference floods typecheck with Sonar errors. Proven on dev-insight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #78. Makes the scaffolded
Directory.Build.propsload SonarAnalyzer only whenCodeAnalysisRuleSetis set, so it is active in the habit-hooks sensor's build but not intypecheck(dotnet build -warnaserror, no ruleset)..editorconfigsuggestion line already kept Sonar toothless in typecheck.Comments in
Directory.Build.propsand.editorconfigupdated to describe the scoped mechanism.