Project 5: Aaron Jiang#20
Open
terskayl wants to merge 10 commits into
Open
Conversation
also fixed a number of bugs. - incorrect num of workgroup dispatched - incorrect quat loading - fixed cov3D - And viewport culling instead of Or refactored covariance into conic.
Updated live demo link and added Google Drive reference for samples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live Demo: https://terskayl.github.io/WebGPU-Gaussian-Splat-Viewer/
Repo Link: https://github.com/terskayl/WebGPU-Gaussian-Splat-Viewer/tree/main
Used 1 late day to finish README
Features
Feedback:
I am not a fan of the base code, especially for moments like using 'auto' for some of the base pipelines when we have learned in lecture to write out all the layouts. I think writing everything out also promotes understanding. I also think the implementation of Radix sort was very opaque - either have the students take a larger role in creating Radix Sort or have a explanation of the interface and how to use it.