Project 4: Utkarsh Dwivedi#12
Open
utkarshdwivedi3997 wants to merge 79 commits into
Open
Conversation
…structions-2021 Update instructions for Fall 2021
Updated dates
Added GUIDataContainer Class to bridge data communication between pathtrace.cu and preview.cpp
Currently it's impossible to "unfocus" the GUI because a bool variable is not updated correctly.
Fix a bug that causes MouseOverImGuiWindow() to not work
…ussian roulette wasn't working :)
…565-Project4-CUDA-Denoiser into denoiser # Conflicts: # INSTRUCTION.md # src/interactions.h # src/main.cpp # src/pathtrace.cu # src/preview.cpp # src/sceneStructs.h
…565-Project4-CUDA-Denoiser into mergeProj3 # Conflicts: # src/interactions.h # src/main.cpp # src/pathtrace.cu # src/preview.cpp # src/sceneStructs.h
…at the end of every iteration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo Link
Features
Feedback
gbufferToPBO()kernel incorrectly multiplies the normalised0 to 1t value by256.0f. This is beyond the colour range and should be255.0f.abs(normal)instead of the correct way of visualising normals(normal + 1) / 2. Taking anabsmakes walls pointing in either left or right directions appear red. This is incorrect and threw me off for a bit while I was working on this assignment, especially since this is coming directly from the image in the instructions!dist2 = max(dot(t,t)/(stepwidth*stepwidth),0.0);but I found that changing it to simplydist2 = dot(t,t);yields MUCH better results.