Klaryfikacja budowania encryptedToken z tokena i timestampa.#823
Open
fsw wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem wykryty podczas pracy nad https://github.com/coffee-software/ksef
Aktualny opis pola
encryptedTokenz/auth/ksef-token:Opis endpointu definiuje wprawdzie że timestamp to "liczba milisekund od 1 stycznia 1970 roku (Unix timestamp)", jednak użyta tutaj nazwa
timestampniefortunnie zbiega się z polemtimestampzwracanym z challenga i może to sugerować użycie tutaj stringa.Problem udało się zdiagnozować dopiero po analizie kodu oficjalnych bibliotek, co ciekawe np
ksef-client-csharpparsuje tutaj poletimestampi zamienia je na unix timestamp (zamiast wykorzystaćtimestampMs). Daje to oczywiście taki sam wynik ale wygląda jak niepotrzebne operacje po stronie klienta.https://github.com/CIRFMF/ksef-client-csharp/blob/9362cc578739ccd4c0b96c3e597b93184dfb8966/KSeF.Client/Api/Services/AuthCoordinator.cs#L33
Rodzi to również pytanie czy pole
timestampjest w ogóle do czegoś potrzebne poza kompatybilnością wsteczną. Być może warto oznaczyć to pole jako deprecated?