Skip to content

ci(plugin-check): use wordpress/plugin-check-action@v1.1.7#7

Open
wzul wants to merge 3 commits into
mainfrom
ci/plugin-check-action-v1.1.7
Open

ci(plugin-check): use wordpress/plugin-check-action@v1.1.7#7
wzul wants to merge 3 commits into
mainfrom
ci/plugin-check-action-v1.1.7

Conversation

@wzul

@wzul wzul commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Error: AI API request timed out after 120 seconds.

wzul added 2 commits June 16, 2026 08:07
Replaces the manual wp-env workaround in the plugin-check job with the
upstream action. Issue #579 ('Environment not initialized') was fixed in
v1.1.7 via PR #590, which drops the URL-plugin bootstrap and installs
plugin-check via WP-CLI after wp-env start with a post-boot check.

Behavior preserved:
- ignore-codes: trademarked_term, NonPrefixedHooknameFound (newline-
  separated per the action's input contract)
- depends on the build/php-compatibility/phpcs/phpunit jobs
- uses PHP 8.2 via shivammathur/setup-php, matching the PHPCS job

Refs: WordPress/plugin-check-action#579, #590
Adds a .github/workflows/ entry to Core Components describing all five
workflows (plugin-check, prepare-release, release-zip, deploy, pr-summary)
with their triggers, secrets, and key behaviors. Also adds two Common
Changes entries for editing ignore-codes and reproducing plugin-check
locally.
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown

✅ WordPress Plugin Check Report

✅ Status: Passed

📊 Report

All checks passed! No errors or warnings found.


🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

…ooks

Introduces two new prefixed hooks as the preferred extension points:
  - gwp_chip_before_info_fields
  - gwp_chip_after_info_fields

The original hooks are kept firing for backward compatibility:
  - give_before_chip_info_fields (deprecated in 1.4.0, will be removed in 2.0.0)
  - give_after_chip_info_fields  (deprecated in 1.4.0, will be removed in 2.0.0)

A _deprecated_hook() notice is emitted (gated on WP_DEBUG via
WordPress's standard helper) so any pre-1.4.0 consumer is told to
migrate.

Critical detail: billing_fields() detaches itself from the legacy hook
on its first invocation there, so our own callback is invoked exactly
once per request even when both hooks fire. Custom listeners on the
legacy hook are not affected (we remove only our own callback).

Also tightens the plugin-check workflow comment for
NonPrefixedHooknameFound to reflect the new state: the ignore is now
justified by both GiveWP-inherited give_* / givewp_* listeners AND
the two legacy give_* hooks we still fire. The inline phpcs:ignore
comments on the legacy do_action calls remain — they only go away
when the old hooks do, in v2.0.0.

Refs: WordPress Coding Standards PrefixAllGlobals discussion
(WPCS#1940). Audit of unprefixed hooks performed 2026-06-16.
@wzul wzul requested a review from amirulazreen June 16, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants