PMP: Fix smooth_shape()#8130
Draft
afabri wants to merge 5 commits into
Draft
Conversation
sloriot
reviewed
Jul 22, 2026
| { | ||
| fill_mass_matrix(); | ||
|
|
||
| std::vector<bool> diag(vertices(mesh_).size(), false); |
Member
There was a problem hiding this comment.
are you sure vimap_ is not in the range 0 -> num_vertices(mesh_)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
When only smoothing a patch the diagonals of the matrix are not set to 1.0
Now the matrix can be factorized but the resulting mesh is wrong. So there is either still another bug, or something is wrong in my fix.
Release Management