chore(deps-dev): Bump pytest from 9.0.3 to 9.1.0#981
Merged
Conversation
848c913 to
c63e783
Compare
Bumps [pytest](https://github.com/pytest-dev/pytest) from 9.0.3 to 9.1.0. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@9.0.3...9.1.0) --- updated-dependencies: - dependency-name: pytest dependency-version: 9.1.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Two failures introduced by pytest 9.1.0: 1. TestCaseLedgerInvariants.completed_workflow was a class-scoped fixture defined as an instance method, deprecated in pytest 9.1.0 (PytestRemovedIn10Warning). Because filterwarnings=['error'] is set in pyproject.toml, the deprecation warning became an error, causing three test ERRORs. Fix: extract the fixture to module level (no self parameter), keeping scope='class' so it runs once per class. 2. PytestUnraisableExceptionWarning fired for an unclosed sqlite3 connection during test_invalidate_report_to_field_uses_case_actor_ when_case_exists in the full suite. Root cause: BTBridge.execute_with_setup already cleaned up the 'datalayer' blackboard key to prevent ResourceWarning, but 'trigger_activity_factory' was intentionally left behind. The TriggerActivityAdapter it references holds a SqliteDataLayer, which holds a sqlite3.Connection. When the previous test's DataLayer was closed (engine disposed) the Python object was still referenced via the global blackboard, delaying GC-triggered ResourceWarning until the next test's setup window — which pytest 9.1.0 promotes to a test failure. Fix: add trigger_activity_factory to managed_keys so it is also restored to its pre-execution state after each BT run. Nested calls remain correct because the RLock is reentrant and previous_values captures the outer call's state. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
c63e783 to
51191d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps pytest from 9.0.3 to 9.1.0.
Release notes
Sourced from pytest's releases.
... (truncated)
Commits
b2522cfPrepare release version 9.1.0368d2fc[refactor] TightenSetComparisonFunctiontoIterator[str](#14587)ff77cd8[refactor] Make base assertion comparisons return an iterator instead of a li...0d8491abuild(deps): Bump actions/stale from 10.2.0 to 10.3.04a809d9Merge pull request #14568 from pytest-dev/register-fixture5dfa385Fix recursion traceback test to cover all styles (#14582)f52ff0cAddpytest.register_fixturea8ac094Merge pull request #14567 from pytest-dev/more-visibility-deprecatee5620cd[pre-commit.ci] pre-commit autoupdate (#14577)2ce9c6dMerge pull request #14540 from minbang930/fix-14533-doctest-module-fixtures