Fix false positives from flaky services and save the probe URLs#2883
Open
imraflip wants to merge 1 commit into
Open
Fix false positives from flaky services and save the probe URLs#2883imraflip wants to merge 1 commit into
imraflip wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A flaky service can return a slightly different response that has nothing to do with ORM injection, which is enough to trip the detector into a false finding. To avoid that, each check now runs a few times (3 by default, set by
ORM_INJECTION_NUM_CONFIRMATIONS) and only counts as a finding if the same parameter keeps showing a difference every time, so a one-off fluke gets dropped. Checks that don't match still stop after the first run, so it doesn't add extra requests for normal cases.I also added the two URLs we actually tested (the matching one and the baseline) to each result under
tested_urls, so it's easy to see what triggered the finding and reproduce it.