fix: execution stats availability messaging#890
Open
cdc-as81 wants to merge 3 commits into
Open
Conversation
Benchmark ResultsHyperfine
CriterionRegressions (slower)
Improvements (faster)
Unchanged / inconclusive (CI crosses 0%)
|
RobertJacobsonCDC
requested changes
May 18, 2026
Collaborator
RobertJacobsonCDC
left a comment
There was a problem hiding this comment.
This is really overwrought. I don't see any real advantage to introducing the ResourceStatisticsStatus enum and resource_statistics_status. You only have two call sites:
print_execution_statisticslog_execution_statistics
Since you're multiplying #[cfg(...)] attributes at every call site and in the definitions of ResourceStatisticsStatus / resource_statistics_status, you've actually make the implementation more complicated by spreading implementation support checks across three different places (on top of introducing a new enum and free function).
Instead, inline the platform support detection at each call site. The logic is something like:
if cfg!(feature = "profiling") {
if cfg!(target_family = "wasm") {
// Or maybe `info!`
warn!("Memory and CPU statistics are not available on your platform.");
}
// Do whatever the function does when profiling is enabled.
} else {
// Do whatever the function does when profiling is disabled.
}
// Do whatever the function does unconditionally.
Benchmark ResultsHyperfine
CriterionRegressions (slower)
Improvements (faster)
Unchanged / inconclusive (CI crosses 0%)
Not Compared (no baseline yet)
|
Benchmark ResultsHyperfine
CriterionRegressions (slower)
Improvements (faster)
Unchanged / inconclusive (CI crosses 0%)
Not Compared (no baseline yet)
|
Benchmark ResultsHyperfine
CriterionRegressions (slower)
Improvements (faster)
Unchanged / inconclusive (CI crosses 0%)
Not Compared (no baseline yet)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Memory and CPU statistics are not available on your platform.whenprofilingis not enabled.--no-statsbehavior unchanged.