[APP-604] feat: Add more options api's to support advanced filters#3232
Open
mcmcgrath13 wants to merge 22 commits into
Open
[APP-604] feat: Add more options api's to support advanced filters#3232mcmcgrath13 wants to merge 22 commits into
mcmcgrath13 wants to merge 22 commits into
Conversation
mcmcgrath13
commented
May 13, 2026
mcmcgrath13
commented
May 13, 2026
mcmcgrath13
commented
May 13, 2026
mcmcgrath13
commented
May 13, 2026
Co-authored-by: Mary McGrath <m.c.mcgrath13@gmail.com>
mcmcgrath13
commented
May 13, 2026
| indent_level_nbr as [order] | ||
| from NBS_SRTE..Condition_code | ||
| where status_cd = 'A' | ||
| and condition_codeset_nm = 'PHC_TYPE' |
Contributor
Author
There was a problem hiding this comment.
this part of the where was missing when translated from nbs 6 query (shouldn't make a difference in practice from what I see, but to be safe ported it over)
mcmcgrath13
commented
May 13, 2026
| from NBS_SRTE..NAICS_Industry_code | ||
| where status_cd = 'A' | ||
| and parent_is_cd = 'root' | ||
| and indent_level_nbr = 1 |
Contributor
Author
There was a problem hiding this comment.
make match the nbs 6 query (though should be equivalent in practice)
mcmcgrath13
commented
May 13, 2026
mcmcgrath13
commented
May 13, 2026
Co-authored-by: Mary McGrath <m.c.mcgrath13@gmail.com>
…dernization into mcm/moar-options
…into mcm/moar-options
mcmcgrath13
changed the title
mcmcgrath13
requested review from
JordanGuinn and
brick-green
and removed request for
a team
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add more endpoints to the options api, so they are available for the advanced filter value sets (https://cdc-nbs.atlassian.net/browse/APP-525).
Notes:
datasource-utilsproject and moved those to a common spot in libs so they could be used for the options api and moddatabase-entitesfor the finding of the column's name and data source, but this somehow introduced a bunch of auth stuff that I don't really understand why and decided it wasn't worth it to figure it out and instead just wrote a little queryTickets
Checklist before requesting a review