Skip to content

Add CngLargeDecryption signature for large payloads#580

Open
kevross33 wants to merge 2 commits into
CAPESandbox:masterfrom
kevross33:patch-526126
Open

Add CngLargeDecryption signature for large payloads#580
kevross33 wants to merge 2 commits into
CAPESandbox:masterfrom
kevross33:patch-526126

Conversation

@kevross33

Copy link
Copy Markdown
Contributor

Sample bcff5812c1bdd518470f91a0b2e5c1e8ed28ba96c58e28953c1e5d9b6cfe9db0
image

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new signature class, CngLargeDecryption, to detect when Windows Cryptography APIs (BCryptDecrypt or CryptDecrypt) are used to decrypt payloads larger than 50KB. Feedback on the changes points out a potential UnboundLocalError if size_raw is referenced without being initialized, suggesting it be explicitly initialized to None before the conditional blocks.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread modules/signatures/windows/cryptography.py Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant