Update AMD build doc AND Make rocshmem device-bitcode arch configurable#174
Open
WhatGhost wants to merge 1 commit into
Open
Update AMD build doc AND Make rocshmem device-bitcode arch configurable#174WhatGhost wants to merge 1 commit into
WhatGhost wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I follow the AMD build flow on
8x AMD Instinct MI350X (gfx950)inside therocm/pytorch:rocm7.1_ubuntu24.04_py3.12_pytorch_release_2.7.1container,using the steps in
docs/build.md. I had met some errors and fix themshmem/rocshmem_bind/scripts/build_rocshmem_device_bc.shhard-codesBITCODE_LIB_ARCH=gfx942(MI300X), so the resulting rocshmem devicebitcode does not fit MI350 (gfx950) or any other non-MI300 GPU.
So i make it configurable and keep gfx942 as default . so that it wont affet users using MI300
docs/build.md(AMD section): fill in a couple of missing/typo steps —add step 0 to detect and
export BITCODE_LIB_ARCH=<gfxXXX>, quote'hip-python>=7.1'(otherwise the shell parses>=7.1as aredirection), and
pip uninstall -y tritonbeforepip install -e pythonto uninstall the origin triton
TEST
bash ./scripts/launch_amd.sh ./python/triton_dist/test/amd/test_ag_gemm_intra_node.py 8192 8192 29568→✅ all close!TRITON_DIST_SHMEM_BACKEND=mori_shmem bash ./scripts/launch_amd.sh ./python/triton_dist/test/amd/test_ep_a2a.py --check→RANK[*]: all checks passed.