fix bugs when device is None in get_full_tflops_approx and add b200 tflops#172
Open
WhatGhost wants to merge 2 commits into
Open
fix bugs when device is None in get_full_tflops_approx and add b200 tflops#172WhatGhost wants to merge 2 commits into
WhatGhost wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds NVIDIA B200 support to the NVIDIA GEMM performance model and fixes the fallback TFLOPS estimation path for unknown GPUs.
Problem
When running the NVIDIA MoE installation test on B200, the test failed before executing the actual MoE kernel. The failure happened while estimating Tensor Core TFLOPS for logging/performance modeling.
B200 was not listed in
get_tensorcore_tflops_by_device_name(), so the code fell back to the estimation path:The fallback path accepted device=None for torch.cuda.get_device_properties(), but then passed the same None into NVML via nvmlDeviceGetHandleByIndex(), which requires an integer device index.
Fix
3.3.3.
The tests passed successfuly after fixing.