Skip to content

refactor(common): add is_transient to Error enum#571

Merged
Byron merged 3 commits into
Byron:mainfrom
raushan728:feat/error-modernization-clean
Feb 14, 2026
Merged

refactor(common): add is_transient to Error enum#571
Byron merged 3 commits into
Byron:mainfrom
raushan728:feat/error-modernization-clean

Conversation

@raushan728

Copy link
Copy Markdown
Contributor

Added an is_transient() method to the Error enum in google-apis-common to help users implement retry strategies. Distinguishes between permanent (e.g., 404) and transient (e.g., 503, 429, IO) errors. No external crates used.

Co-authored-by: Gemini <gemini@google.com>

@Byron Byron left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this looks good to me once some small things have been addressed.
Thanks again.

Edit: And thanks for the disclosure. It's too bad commits are really easy to not see on GitHub.

Comment thread google-apis-common/src/lib.rs
Comment thread google-apis-common/src/lib.rs
…docs

Co-authored-by: Gemini <gemini@google.com>
@raushan728

Copy link
Copy Markdown
Contributor Author

I took your suggestion to heart and enabled #![deny(missing_docs)] at the crate level for google-apis-common.
To satisfy the lint, I have documented all public items across lib.rs, auth.rs, serde.rs, and url.rs. This ensures that the crate remains fully documented and follows Rust best practices going forward

@raushan728

Copy link
Copy Markdown
Contributor Author

@Byron plz take a look

@Byron

Byron commented Feb 14, 2026

Copy link
Copy Markdown
Owner

Thanks a lot! I didn't realise how much still needed to be documented, and I am sorry for putting that on you.

With that said, I re-ran the documentation generation with Codex to get something much less generic.

@Byron Byron merged commit 5e66262 into Byron:main Feb 14, 2026
6 checks passed
@raushan728 raushan728 deleted the feat/error-modernization-clean branch February 14, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants