Skip to content

fix(msi): roll back a failed upgrade; deployment-token note (review of #555) - #556

Merged
Warhammer4000 merged 2 commits into
devfrom
fix/555-review
Nov 20, 2026
Merged

Warhammer4000 merged 2 commits into
devfrom
fix/555-review

Conversation

@Warhammer4000

@Warhammer4000 Warhammer4000 commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Addresses CodeRabbit's two comments on #555.

  • installer/msi/sentinelgo.wxs: MajorUpgrade Schedule="afterInstallInitialize". The old product is now removed inside the install transaction, so a failed install rolls it back. Before, the device was left with no agent. Since feat(installers): read-only MSI and macOS package (#550) #554, every same-version flavor switch goes through this path. build.ps1 now checks that RemoveExistingProducts runs between InstallInitialize and InstallFiles. Checked locally: building from the old .wxs fails the check, and both MSIs from the new one pass.
  • INSTALLATION.md: the read-only MSI can't enroll until BrainStation-23/Compliance-OS#1082 issues deployment tokens. Until then, use the per-device download or install.bat --readonly.

Changelog: 556-msi-upgrade-rollback.fixed.md.

🤖 Generated with Claude Code


Devin Review

…deployment tokens aren't issued yet

Addresses the review of #555.

- MajorUpgrade Schedule=afterInstallInitialize: a failed install, now
  also every same-version flavor switch, rolls back the removal instead
  of leaving the device with no agent. build.ps1 checks the sequence.
- INSTALLATION.md: the read-only MSI can't enroll until Compliance-OS#1082
  issues deployment tokens; points to the per-device download and
  install.bat --readonly meanwhile.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Warhammer4000 Warhammer4000 added the skip-changelog No user-visible change; no CHANGELOG.md entry needed label Nov 20, 2026
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ca9f41df-42a7-41d3-84f3-ce7ecce821e7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

Comment on lines +53 to +54
<MajorUpgrade Schedule="afterInstallInitialize"
AllowSameVersionUpgrades="yes"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Missing release note for upgrade recovery

The MajorUpgrade rollback fix has no new changelog fragment. Contribution rules require one for each user-visible change. The existing read-only installer fragment does not cover failed-upgrade recovery.

Learn more

The repository requires each user-visible fix to add its own changelog fragment. The existing installer entry describes read-only installers and flavor replacement, not failed-upgrade recovery. The fragment check checks newly added files against the PR base, so an earlier PR's fragment does not satisfy it without an exemption.

Example: An administrator reading the next release notes sees flavor-switch support but no mention that failed Windows upgrades now restore the previous installation.

Recommended fix: Add changelog.d/556-msi-upgrade-rollback.fixed.md with a - entry describing restoration of the previous agent when an MSI upgrade fails.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added changelog.d/556-msi-upgrade-rollback.fixed.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Warhammer4000 Warhammer4000 removed the skip-changelog No user-visible change; no CHANGELOG.md entry needed label Nov 20, 2026
@sonarqubecloud

Copy link
Copy Markdown

@Warhammer4000
Warhammer4000 merged commit f91ea96 into dev Nov 20, 2026
24 of 25 checks passed
@Warhammer4000
Warhammer4000 deleted the fix/555-review branch November 20, 2026 04:04
@Warhammer4000 Warhammer4000 mentioned this pull request Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant