Repository navigation
fix(msi): roll back a failed upgrade; deployment-token note (review of #555) - #556
Conversation
…deployment tokens aren't issued yet Addresses the review of #555. - MajorUpgrade Schedule=afterInstallInitialize: a failed install, now also every same-version flavor switch, rolls back the removal instead of leaving the device with no agent. build.ps1 checks the sequence. - INSTALLATION.md: the read-only MSI can't enroll until Compliance-OS#1082 issues deployment tokens; points to the per-device download and install.bat --readonly meanwhile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
There was a problem hiding this comment.
Devin Review found 1 potential issue.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
| <MajorUpgrade Schedule="afterInstallInitialize" | ||
| AllowSameVersionUpgrades="yes" |
There was a problem hiding this comment.
🟡 Missing release note for upgrade recovery
The MajorUpgrade rollback fix has no new changelog fragment. Contribution rules require one for each user-visible change. The existing read-only installer fragment does not cover failed-upgrade recovery.
Learn more
The repository requires each user-visible fix to add its own changelog fragment. The existing installer entry describes read-only installers and flavor replacement, not failed-upgrade recovery. The fragment check checks newly added files against the PR base, so an earlier PR's fragment does not satisfy it without an exemption.
Example: An administrator reading the next release notes sees flavor-switch support but no mention that failed Windows upgrades now restore the previous installation.
Recommended fix: Add changelog.d/556-msi-upgrade-rollback.fixed.md with a - entry describing restoration of the previous agent when an MSI upgrade fails.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Added changelog.d/556-msi-upgrade-rollback.fixed.md.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|



Addresses CodeRabbit's two comments on #555.
installer/msi/sentinelgo.wxs:MajorUpgrade Schedule="afterInstallInitialize". The old product is now removed inside the install transaction, so a failed install rolls it back. Before, the device was left with no agent. Since feat(installers): read-only MSI and macOS package (#550) #554, every same-version flavor switch goes through this path.build.ps1now checks that RemoveExistingProducts runs between InstallInitialize and InstallFiles. Checked locally: building from the old.wxsfails the check, and both MSIs from the new one pass.INSTALLATION.md: the read-only MSI can't enroll until BrainStation-23/Compliance-OS#1082 issues deployment tokens. Until then, use the per-device download orinstall.bat --readonly.Changelog:
556-msi-upgrade-rollback.fixed.md.🤖 Generated with Claude Code