Skip to content

refactor(core): move Schedule, GenUI, Memory and attachment tools into feature folders (H-2 step 22) - #4797

Merged
DoodleBears merged 2 commits into
mainfrom
codex/4521-feature-22-adapter-tools
Nov 20, 2026
Merged

DoodleBears merged 2 commits into
mainfrom
codex/4521-feature-22-adapter-tools

Conversation

@DoodleBears

Copy link
Copy Markdown
Contributor

H-2 step 22 plan | Agent work claim

Refs #4521

Harness: codex
Model: gpt-6.2-sol
Agent-Task: codex/local/01a1faff-7c75-7111-a0ea-6a1701fad897

Why the change

Give Schedule, GenUI, Memory and Channel files ownership of their tool definitions and prompt contributions while the DSH Agent adapter continues to own registration and native Agent lifecycle.

Special things to note

  • Merge risk: Two-way door, revert the commit to restore the original file layout. Medium blast radius, because Orchestrator turns and direct tools share this registration path. Review the invocation-time run lookup and the placement of each registration.
  • Verification: Byte-identical fixture captures on the base and head covered tool names, descriptions, input and output schemas, tool registration order, prompt section IDs and priorities, and assembled prompt text across standard and Tob CLI runs with IM connected and disconnected. The 57-entry direct-tool catalogue also matched. Tool Effects declarations are identical.
  • The existing standard tool-order test now has companion assertions for external IM tool order and prompt-section order. The original GenUI factory imports resolve through compatibility exports.

Change outline

packages/core/src/
├── runtime/dsh-bot-agent-adapter.ts       5,613 → 4,937 lines
└── features/
    ├── schedules/      tools.ts 259 · prompt.ts 5
    ├── genui/          tools.ts 133 · prompt.ts 7
    ├── memory/         tools.ts 120 · prompt.ts 3
    └── channel-files/  tools.ts 343 · prompt.ts 3

…ders

Issue: #4521
Agent-Task: codex/local/01a1faff-7c75-7111-a0ea-6a1701fad897
@DoodleBears DoodleBears added harness:codex model:gpt-6.2-sol Code authored by GPT-6.2 Sol labels Nov 20, 2026
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 4242427 and 8f11f4d.

Files selected for processing: 15

  • docs/architecture/botharness-architecture.md
  • docs/architecture/feature-map.md
  • packages/core/src/features/channel-files/prompt.ts
  • packages/core/src/features/channel-files/tools.ts
  • packages/core/src/features/genui/prompt.ts
  • packages/core/src/features/genui/tools.ts
  • packages/core/src/features/memory/prompt.ts
  • packages/core/src/features/memory/tools.ts
  • packages/core/src/features/schedules/prompt.ts
  • packages/core/src/features/schedules/tools.ts
  • packages/core/src/runtime/dsh-bot-agent-adapter.ts
  • packages/core/src/runtime/genui-diagram-tool.ts
  • packages/core/src/runtime/genui-preview-tool.ts
  • packages/core/test/dsh-agent-host-fixture.ts
  • packages/core/test/dsh-bot-agent-adapter.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Issue: #4521
Agent-Task: codex/local/01a1faff-7c75-7111-a0ea-6a1701fad897
@DoodleBears
DoodleBears merged commit d793427 into main Nov 20, 2026
21 checks passed
@DoodleBears
DoodleBears deleted the codex/4521-feature-22-adapter-tools branch November 20, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

harness:codex model:gpt-6.2-sol Code authored by GPT-6.2 Sol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant